lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:   Tue, 5 May 2020 10:15:05 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Christophe Jaillet <christophe.jaillet@...adoo.fr>,
        linux-arm-kernel@...ts.infradead.org, linux-media@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        Chen-Yu Tsai <wens@...e.org>,
        Hans Verkuil <hverkuil-cisco@...all.nl>,
        Jernej Skrabec <jernej.skrabec@...l.net>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Maxime Ripard <mripard@...nel.org>
Subject: Re: [PATCH] media: sun8i: Fix an error handling path in
 deinterlace_runtime_resume()

> It is spurious to call 'clk_disable_unprepare()' when
> 'clk_prepare_enable()' has not been called yet.

Can it be that the usage of the word “suspicious” would be more appropriate
for such a change description?


> Re-order the error handling path to avoid it.

Would it be also helpful to explicitly mention in the commit message
that you would like to move a call of the function “clk_rate_exclusive_put”
to the end of this function implementation for the correction
of the desired exception handling?

Regards,
Markus

Powered by blists - more mailing lists