lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 5 May 2020 12:50:23 +0200
From:   Christoph Hellwig <>
To:     Jann Horn <>
Cc:     Andrew Morton <>,
        Linus Torvalds <>,
        Christoph Hellwig <>,,,,
        Alexander Viro <>,
        "Eric W . Biederman" <>,
        Oleg Nesterov <>,
        Russell King <>,,
        Mark Salter <>,
        Aurelien Jacquiot <>,,
        Yoshinori Sato <>,
        Rich Felker <>,
Subject: Re: [PATCH v2 3/5] coredump: Refactor page range dumping into
 common helper

On Wed, Apr 29, 2020 at 11:49:52PM +0200, Jann Horn wrote:
> Both fs/binfmt_elf.c and fs/binfmt_elf_fdpic.c need to dump ranges of pages
> into the coredump file. Extract that logic into a common helper.
> Any other binfmt that actually wants to create coredumps will probably need
> the same function; so stop making get_dump_page() depend on

Why is the #ifdef CONFIG_ELF_CORE in gup.c removed when the only
remaining caller is under the same ifdef?

Otherwise this looks fine to me.

Powered by blists - more mailing lists