lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Tue, 5 May 2020 13:32:58 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Ben Chuang <benchuanggli@...il.com>
Cc:     Adrian Hunter <adrian.hunter@...el.com>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Ben Chuang <ben.chuang@...esyslogic.com.tw>,
        renius.chen@...esyslogic.com.tw, custos.mentis@...il.com
Subject: Re: [PATCH] mmc: sdhci-pci-gli: Fix can not access GL9750 after
 reboot from Windows 10

On Mon, 4 May 2020 at 08:41, Ben Chuang <benchuanggli@...il.com> wrote:
>
> From: Ben Chuang <ben.chuang@...esyslogic.com.tw>
>
> Need to clear some bits in a vendor-defined register after reboot from
> Windows 10.
>
> Fixes: e51df6ce668a ("mmc: host: sdhci-pci: Add Genesys Logic GL975x support")
> Reported-by: Grzegorz Kowal <custos.mentis@...il.com>
> Signed-off-by: Ben Chuang <ben.chuang@...esyslogic.com.tw>

Applied for fixes, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/sdhci-pci-gli.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/mmc/host/sdhci-pci-gli.c b/drivers/mmc/host/sdhci-pci-gli.c
> index ce15a05f23d4..8170b659f2af 100644
> --- a/drivers/mmc/host/sdhci-pci-gli.c
> +++ b/drivers/mmc/host/sdhci-pci-gli.c
> @@ -26,6 +26,9 @@
>  #define   SDHCI_GLI_9750_DRIVING_2    GENMASK(27, 26)
>  #define   GLI_9750_DRIVING_1_VALUE    0xFFF
>  #define   GLI_9750_DRIVING_2_VALUE    0x3
> +#define   SDHCI_GLI_9750_SEL_1        BIT(29)
> +#define   SDHCI_GLI_9750_SEL_2        BIT(31)
> +#define   SDHCI_GLI_9750_ALL_RST      (BIT(24)|BIT(25)|BIT(28)|BIT(30))
>
>  #define SDHCI_GLI_9750_PLL           0x864
>  #define   SDHCI_GLI_9750_PLL_TX2_INV    BIT(23)
> @@ -122,6 +125,8 @@ static void gli_set_9750(struct sdhci_host *host)
>                                     GLI_9750_DRIVING_1_VALUE);
>         driving_value |= FIELD_PREP(SDHCI_GLI_9750_DRIVING_2,
>                                     GLI_9750_DRIVING_2_VALUE);
> +       driving_value &= ~(SDHCI_GLI_9750_SEL_1|SDHCI_GLI_9750_SEL_2|SDHCI_GLI_9750_ALL_RST);
> +       driving_value |= SDHCI_GLI_9750_SEL_2;
>         sdhci_writel(host, driving_value, SDHCI_GLI_9750_DRIVING);
>
>         sw_ctrl_value &= ~SDHCI_GLI_9750_SW_CTRL_4;
> --
> 2.26.2
>

Powered by blists - more mailing lists