linux-kernel - Re: [PATCH v12 2/5] usb: renesas-xhci: Add the renesas xhci driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 5 May 2020 14:05:09 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Vinod Koul <vkoul@...nel.org>
Cc:     Mathias Nyman <mathias.nyman@...ux.intel.com>,
        Mathias Nyman <mathias.nyman@...el.com>,
        linux-arm-msm@...r.kernel.org,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Christian Lamparter <chunkeey@...glemail.com>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        John Stultz <john.stultz@...aro.org>,
        Alan Stern <stern@...land.harvard.edu>,
        Andreas Böhler <dev@...ehler.at>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v12 2/5] usb: renesas-xhci: Add the renesas xhci driver

On Tue, May 05, 2020 at 05:03:54PM +0530, Vinod Koul wrote:
> On 05-05-20, 13:04, Greg Kroah-Hartman wrote:
> > On Mon, May 04, 2020 at 08:04:38PM +0530, Vinod Koul wrote:
> 
> > > > > --- a/drivers/usb/host/Makefile
> > > > > +++ b/drivers/usb/host/Makefile
> > > > > @@ -70,7 +70,7 @@ obj-$(CONFIG_USB_OHCI_HCD_DAVINCI)	+= ohci-da8xx.o
> > > > >  obj-$(CONFIG_USB_UHCI_HCD)	+= uhci-hcd.o
> > > > >  obj-$(CONFIG_USB_FHCI_HCD)	+= fhci.o
> > > > >  obj-$(CONFIG_USB_XHCI_HCD)	+= xhci-hcd.o
> > > > > -obj-$(CONFIG_USB_XHCI_PCI)	+= xhci-pci.o
> > > > > +obj-$(CONFIG_USB_XHCI_PCI)	+= xhci-pci.o xhci-pci-renesas.o
> > > > 
> > > > Hmm, now we end up with two modules, xhci-pci and xhci-pci-renesas, even if
> > > > xhci-pci-renesas just includes helper functions to load firmware for renesas.
> > > 
> > > Right, these are two modules. Do you forsee an issue with two ko's
> > 
> > Two kos should be fine, but as you aren't giving people the option to
> > not select this, it's a bit harsh to add it.
> > 
> > Can this be a separate module/config option?  Why force everyone to need
> > this additional code if they do not have this hardware?
> 
> Since the code is moved out and is based on PCI ID of the device, this
> wont be invoked at all for folks not having this hardware. But adding a
> config option would work too and avoid renaming file.

Yes, it would not be "invoked", but it still would always be loaded into
memory.  Please only load this code if the hardware is present in the
system.

thanks,

greg k-h