linux-kernel - Re: [PATCH v2 0/3] Improvements for kallsyms_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 5 May 2020 09:38:00 -0300
From:   Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
To:     Ian Rogers <irogers@...gle.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-kernel@...r.kernel.org, Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH v2 0/3] Improvements for kallsyms__parse

Em Fri, May 01, 2020 at 03:13:12PM -0700, Ian Rogers escreveu:
> kallsyms__parse is called 4 times during perf record startup. Add a
> benchmark to measure its performance. Transition it to using the api
> io.h buffered reading, improving performance by ~8% or saving ~5% from
> perf record start up time.
> 
> v2. Fix the err return value for success, error reported by
>     jolsa@...hat.com. Add clean-up for hex2u64.

Thanks, applied. Jiri, please let me know if I can stick your Acked-by
or, better, Reviewed-by there, Namhyung, others, please consider doing
the same :-)

- Arnaldo
 
> Ian Rogers (3):
>   perf bench: add kallsyms parsing
>   lib kallsyms: parse using io api
>   lib kallsyms: move hex2u64 out of header
> 
>  tools/lib/api/io.h                |  3 ++
>  tools/lib/symbol/kallsyms.c       | 86 ++++++++++++++-----------------
>  tools/lib/symbol/kallsyms.h       |  2 -
>  tools/perf/bench/Build            |  1 +
>  tools/perf/bench/bench.h          |  1 +
>  tools/perf/bench/kallsyms-parse.c | 75 +++++++++++++++++++++++++++
>  tools/perf/builtin-bench.c        |  1 +
>  tools/perf/util/symbol.c          | 14 +++++
>  8 files changed, 133 insertions(+), 50 deletions(-)
>  create mode 100644 tools/perf/bench/kallsyms-parse.c
> 
> -- 
> 2.26.2.526.g744177e7f7-goog
> 

-- 

- Arnaldo