linux-kernel - Re: [PATCH v3] ipmi:bt-bmc: Fix error handling and status check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3610b0fb-25f5-1bf9-a3c1-1c7ca113a9c8@cmss.chinamobile.com>
Date:   Tue, 5 May 2020 20:59:51 +0800
From:   Tang Bin <tangbin@...s.chinamobile.com>
To:     minyard@....org
Cc:     arnd@...db.de, gregkh@...uxfoundation.org,
        openipmi-developer@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org,
        Shengju Zhang <zhangshengju@...s.chinamobile.com>
Subject: Re: [PATCH v3] ipmi:bt-bmc: Fix error handling and status check

Hi, Corey:

On 2020/5/5 19:49, Corey Minyard wrote:
> On Tue, May 05, 2020 at 06:29:06PM +0800, Tang Bin wrote:
>> If the function platform_get_irq() failed, the negative value
>> returned will not be detected here. So fix error handling in
>> bt_bmc_config_irq(). And in the function bt_bmc_probe(),
>> when get irq failed, it will print error message. So use
>> platform_get_irq_optional() to simplify code. Finally in the
>> function bt_bmc_remove() should make the right status check
>> if get irq failed.
> Ok, this is included in my tree.

I just want to say: thank you very much.

After many days of communication with you, I have learned a lot, your 
patient teaching has inspired me a lot. It's my pleasure to meet you.

Thanks,

Tang Bin

>