linux-kernel - Re: [PATCH v3 09/17] mmc: sdhci-msm: Fix error handling for dev_pm_opp_of_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 5 May 2020 19:02:47 +0530
From:   Rajendra Nayak <rnayak@...eaurora.org>
To:     Ulf Hansson <ulf.hansson@...aro.org>
Cc:     Viresh Kumar <viresh.kumar@...aro.org>,
        Stephen Boyd <sboyd@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Andy Gross <agross@...nel.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        DTML <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Matthias Kaehlcke <mka@...omium.org>,
        Pradeep P V K <ppvk@...eaurora.org>,
        Veerabhadrarao Badiganti <vbadigan@...eaurora.org>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>
Subject: Re: [PATCH v3 09/17] mmc: sdhci-msm: Fix error handling for
 dev_pm_opp_of_add_table()


On 5/5/2020 5:03 PM, Ulf Hansson wrote:
> On Wed, 29 Apr 2020 at 16:09, Rajendra Nayak <rnayak@...eaurora.org> wrote:
>>
>>
>> On 4/28/2020 11:59 PM, Ulf Hansson wrote:
>>> On Tue, 28 Apr 2020 at 15:39, Rajendra Nayak <rnayak@...eaurora.org> wrote:
>>>>
>>>> Even though specifying OPP's in device tree is optional, ignoring all errors
>>>> reported by dev_pm_opp_of_add_table() means we can't distinguish between a
>>>> missing OPP table and a wrong/buggy OPP table. While missing OPP table
>>>> (dev_pm_opp_of_add_table() returns a -ENODEV in such case) can be ignored,
>>>> a wrong/buggy OPP table in device tree should make the driver error out.
>>>>
>>>> while we fix that, lets also fix the variable names for opp/opp_table to
>>>> avoid confusion and name them opp_table/has_opp_table instead.
>>>>
>>>> Suggested-by: Matthias Kaehlcke <matthias@...omium.org>
>>>> Signed-off-by: Rajendra Nayak <rnayak@...eaurora.org>
>>>> Cc: Ulf Hansson <ulf.hansson@...aro.org>
>>>> Cc: Pradeep P V K <ppvk@...eaurora.org>
>>>> Cc: Veerabhadrarao Badiganti <vbadigan@...eaurora.org>
>>>> Cc: linux-mmc@...r.kernel.org
>>>
>>> Is this a standalone patch that I queue up via my mmc tree?
>>
>> Hi Ulf, yes, its a standalone patch which applies on top of the one
>> you already have in your tree. No other dependencies.
> 
> Thanks for confirming! Perhaps next time you could add this
> information as part of a description to the patch (where we usually
> add patch version information).
> 
> Anyway, applied for next!

Thanks Ulf, I should have sent this out as a standalone patch instead of including
it with the reset of the series, which caused the confusion. Sorry about that :/

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation