[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 5 May 2020 17:15:16 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Calvin Johnson <calvin.johnson@....nxp.com>
Cc: "Rafael J . Wysocki" <rafael@...nel.org>,
Russell King - ARM Linux admin <linux@...linux.org.uk>,
linux.cj@...il.com, Jeremy Linton <jeremy.linton@....com>,
Andrew Lunn <andrew@...n.ch>,
Florian Fainelli <f.fainelli@...il.com>,
Cristi Sovaiala <cristian.sovaiala@....com>,
Florin Laurentiu Chiculita <florinlaurentiu.chiculita@....com>,
Ioana Ciornei <ioana.ciornei@....com>,
Madalin Bucur <madalin.bucur@....nxp.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
Varun Sethi <V.Sethi@....com>,
"Rajesh V . Bikkina" <rajesh.bikkina@....com>,
ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Diana Madalina Craciun <diana.craciun@....com>,
netdev <netdev@...r.kernel.org>, Marcin Wojtas <mw@...ihalf.com>,
Laurentiu Tudor <laurentiu.tudor@....com>,
Makarand Pawagi <makarand.pawagi@....com>,
linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
Pankaj Bansal <pankaj.bansal@....com>,
"David S. Miller" <davem@...emloft.net>,
Heiner Kallweit <hkallweit1@...il.com>
Subject: Re: [net-next PATCH v3 4/5] net: phy: Introduce fwnode_get_phy_id()
On Tue, May 5, 2020 at 4:29 PM Calvin Johnson
<calvin.johnson@....nxp.com> wrote:
>
> Extract phy_id from compatible string. This will be used by
> fwnode_mdiobus_register_phy() to create phy device using the
> phy_id.
> +int fwnode_get_phy_id(struct fwnode_handle *fwnode, u32 *phy_id)
> +{
> + const char *cp;
> + unsigned int upper, lower;
> + int ret;
> +
> + ret = fwnode_property_read_string(fwnode, "compatible", &cp);
> + if (!ret) {
if (ret)
return ret;
will help a lot with readability of this.
> + if (sscanf(cp, "ethernet-phy-id%4x.%4x",
> + &upper, &lower) == 2) {
> + *phy_id = ((upper & 0xFFFF) << 16) | (lower & 0xFFFF);
How upper can be bigger than 0xfff? Same for lower.
> + return 0;
> + }
> + }
> + return -EINVAL;
> +}
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists