linux-kernel - RE: [EXT] [PATCH] scsi: qedi: remove Comparison of 0/1 to bool variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 6 May 2020 04:43:25 +0000
From:   Manish Rangankar <mrangankar@...vell.com>
To:     Jason Yan <yanaijie@...wei.com>,
        "QLogic-Storage-Upstream@...ium.com" 
        <QLogic-Storage-Upstream@...ium.com>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [EXT] [PATCH] scsi: qedi: remove Comparison of 0/1 to bool
 variable


> -----Original Message-----
> From: Jason Yan <yanaijie@...wei.com>
> Sent: Thursday, April 30, 2020 5:47 PM
> To: QLogic-Storage-Upstream@...ium.com; jejb@...ux.ibm.com;
> martin.petersen@...cle.com; Manish Rangankar
> <mrangankar@...vell.com>; linux-scsi@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Cc: Jason Yan <yanaijie@...wei.com>
> Subject: [EXT] [PATCH] scsi: qedi: remove Comparison of 0/1 to bool
> variable
> 
> External Email
> 
> ----------------------------------------------------------------------
> Fix the following coccicheck warning:
> 
> drivers/scsi/qedi/qedi_main.c:1309:5-25: WARNING: Comparison of 0/1 to
> bool variable
> drivers/scsi/qedi/qedi_main.c:1315:5-25: WARNING: Comparison of 0/1 to
> bool variable
> 
> Signed-off-by: Jason Yan <yanaijie@...wei.com>
> ---
>  drivers/scsi/qedi/qedi_main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c
> index 4dd965860c98..46584e16d635 100644
> --- a/drivers/scsi/qedi/qedi_main.c
> +++ b/drivers/scsi/qedi/qedi_main.c
> @@ -1306,13 +1306,13 @@ static irqreturn_t qedi_msix_handler(int irq,
> void *dev_id)
>  			  "process already running\n");
>  	}
> 
> -	if (qedi_fp_has_work(fp) == 0)
> +	if (!qedi_fp_has_work(fp))
>  		qed_sb_update_sb_idx(fp->sb_info);
> 
>  	/* Check for more work */
>  	rmb();
> 
> -	if (qedi_fp_has_work(fp) == 0)
> +	if (!qedi_fp_has_work(fp))
>  		qed_sb_ack(fp->sb_info, IGU_INT_ENABLE, 1);
>  	else
>  		goto process_again;
> --

Thanks,
Acked-by: Manish Rangankar <mrangankar@...vell.com>