linux-kernel - Re: MAINTAINERS: Wrong ordering in S390 PCI SUBSYSTEM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 06 May 2020 10:09:11 -0700
From:   Joe Perches <joe@...ches.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>,
        Lukas Bulwahn <lukas.bulwahn@...il.com>
Cc:     Pierre Morel <pmorel@...ux.ibm.com>,
        Vasily Gorbik <gor@...ux.ibm.com>,
        kernel-janitors@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: MAINTAINERS: Wrong ordering in S390 PCI SUBSYSTEM

On Wed, 2020-05-06 at 13:51 +0300, Andy Shevchenko wrote:
> On Wed, May 6, 2020 at 8:46 AM Lukas Bulwahn <lukas.bulwahn@...il.com> wrote:
> > Hi Pierre,
> > 
> > with your commit de267a7c71ba ("s390/pci: Documentation for zPCI"),
> > visible on next-20200505, ./scripts/checkpatch.pl -f MAINTAINERS
> > complains:
> > 
> > WARNING: Misordered MAINTAINERS entry - list file patterns in alphabetic order
> > #14723: FILE: MAINTAINERS:14723:
> > +F:     drivers/pci/hotplug/s390_pci_hpc.c
> > +F:     Documentation/s390/pci.rst
> > 
> > 
> > This is due to wrong ordering of the entries in your submission. If you
> > would like me to send you a patch fixing that, please just let me know.
> > 
> > It is a recent addition to checkpatch.pl to report ordering problems in
> > MAINTAINERS, so you might have not seen that at submission time.
> 
> Why not to send a patch?
> Same for the rest of similar mails from you.

Frequently an original patch, which has yet to hit Linus' tree,
can be updated before being upstreamed to avoid unnecessary
additional patches.

It's also good form so the author of the original patch can be
aware of possible defects in submission.