lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 6 May 2020 16:12:51 -0400 From: Alex Deucher <alexdeucher@...il.com> To: ChenTao <chentao107@...wei.com> Cc: Dave Airlie <airlied@...ux.ie>, Daniel Vetter <daniel@...ll.ch>, LKML <linux-kernel@...r.kernel.org>, Maling list - DRI developers <dri-devel@...ts.freedesktop.org>, amd-gfx list <amd-gfx@...ts.freedesktop.org>, "Deucher, Alexander" <alexander.deucher@....com>, Christian Koenig <christian.koenig@....com> Subject: Re: [PATCH -next] drm/amdgpu/navi10: fix unsigned comparison with 0 On Wed, May 6, 2020 at 3:03 AM ChenTao <chentao107@...wei.com> wrote: > > Fixes warning because size is uint32_t and can never be negtative > > drivers/gpu/drm/amd/amdgpu/../powerplay/navi10_ppt.c:1296:12: warning: > comparison of unsigned expression < 0 is always false [-Wtype-limits] > if (size < 0) > > Reported-by: Hulk Robot <hulkci@...wei.com> > Signed-off-by: ChenTao <chentao107@...wei.com> Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c b/drivers/gpu/drm/amd/powerplay/navi10_ppt.c > index 2184d247a9f7..0c9be864d072 100644 > --- a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c > +++ b/drivers/gpu/drm/amd/powerplay/navi10_ppt.c > @@ -1293,8 +1293,6 @@ static int navi10_set_power_profile_mode(struct smu_context *smu, long *input, u > } > > if (smu->power_profile_mode == PP_SMC_POWER_PROFILE_CUSTOM) { > - if (size < 0) > - return -EINVAL; > > ret = smu_update_table(smu, > SMU_TABLE_ACTIVITY_MONITOR_COEFF, WORKLOAD_PPLIB_CUSTOM_BIT, > -- > 2.22.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@...ts.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
Powered by blists - more mailing lists