linux-kernel - Re: x86/uv cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 6 May 2020 16:36:50 -0500
From:   Russ Anderson <rja@....com>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     Dimitri Sivanich <sivanich@....com>,
        Christoph Hellwig <hch@....de>, x86@...nel.org,
        Mike Travis <mike.travis@....com>,
        Russ Anderson <russ.anderson@....com>,
        linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Steve Wahl <steve.wahl@....com>
Subject: Re: x86/uv cleanups

On Wed, May 06, 2020 at 01:14:40AM +0200, Thomas Gleixner wrote:
> Dimitri Sivanich <sivanich@....com> writes:
> > Yes, we do see a need to clean up old code where it exists, but we would like
> > to assume this responsibility ourselves in order to ensure functional continuity
> > with externally available open-sourced modules that our customers rely on.  This
> > code supports current Superdome Flex systems, as well as forthcoming platforms
> > based on Intel Cooper Lake and Sapphire Rapids processors.  Some cleanup is
> > already being included as part of a forthcoming patchset in support of the
> > upcoming Sapphire Rapids platform.
> 
> That's a completely bogus argument.
> 
>  1) You could have cleaned up that code long ago
> 
>  2) The rule for code which is unused in the mainline kernel is that it
>     can be removed during spring cleaning unless there is a compelling
>     reason. I can't see one here.
> 
>  3) Out of tree modules are not supported independent of the license.
>     It's not our problem that you have code out of tree which you could
>     have upstreamed long ago.
> 
> Look at the history of platform/uv code. All we see from you guys is:
> 
>  - Drops of adding support for new platforms
> 
>  - Occasional fixes when we managed to break UV or you found some bug in
>    your precious code.
> 
> > Nacked-by: Dimitri Sivanich <sivanich@....com>
> 
> I'm happy to add that tag when merging this cleanup.
> 
> Thanks,
> 
>         tglx

Thomas (and all)

Sorry.  We do need to do better.

In addition to Christoph's patches, we will soon be submitting
additional clean up patches.  Mike Travis is working on a patch
to remove old SGI UV1 code.  Dimitri Sivanich is working on a
sgi_rtc cleanup patch.  We are looking at additional cleanup
that should have been done previously.

Steve Wahl will be involved on an ongoing basis, so
you will see more from us.

Thanks.
-- 
Russ Anderson,  SuperDome Flex Linux Kernel Group Manager
HPE - Hewlett Packard Enterprise (formerly SGI)  rja@....com