linux-kernel - Re: [PATCH net] net: macsec: fix rtnl locking issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200506.145015.1852712055909777150.davem@davemloft.net>
Date:   Wed, 06 May 2020 14:50:15 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     antoine.tenart@...tlin.com
Cc:     sd@...asysnail.net, mstarovoitov@...vell.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: macsec: fix rtnl locking issue

From: Antoine Tenart <antoine.tenart@...tlin.com>
Date: Wed,  6 May 2020 15:58:30 +0200

> netdev_update_features() must be called with the rtnl lock taken. Not
> doing so triggers a warning, as ASSERT_RTNL() is used in
> __netdev_update_features(), the first function called by
> netdev_update_features(). Fix this.
> 
> Fixes: c850240b6c41 ("net: macsec: report real_dev features when HW offloading is enabled")
> Signed-off-by: Antoine Tenart <antoine.tenart@...tlin.com>

Applied, thank you.