lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 6 May 2020 10:59:55 +0530
From:   Srikar Dronamraju <>
To:     Oleg Nesterov <>
Cc:     Guo Ren <>,
        Christian Borntraeger <>,
        "David S. Miller" <>,
        Linus Torvalds <>,
        Steven Rostedt <>,
        "Eric W. Biederman" <>,
        Peter Zijlstra <>,
        Ingo Molnar <>, Jann Horn <>,
        Al Viro <>,
        Jens Axboe <>,
        Security Officers <>,
        Andrea Arcangeli <>,
        Ananth N Mavinakayanahalli <>,
        Naveen Rao <>,
        Andrew Morton <>,
Subject: Re: [PATCH] uprobes: ensure that uprobe->offset and ->ref_ctr_offset
 are properly aligned

* Oleg Nesterov <> [2020-05-04 18:47:25]:

> uprobe_write_opcode() must not cross page boundary; prepare_uprobe()
> relies on arch_uprobe_analyze_insn() which should validate "vaddr" but
> some architectures (csky, s390, and sparc) don't do this.
> We can remove the BUG_ON() check in prepare_uprobe() and validate the
> offset early in __uprobe_register(). The new IS_ALIGNED() check matches
> the alignment check in arch_prepare_kprobe() on supported architectures,
> so I think that all insns must be aligned to UPROBE_SWBP_INSN_SIZE.
> Another problem is __update_ref_ctr() which was wrong from the very
> beginning, it can read/write outside of kmap'ed page unless "vaddr" is
> aligned to sizeof(short), __uprobe_register() should check this too.
> Cc:
> Reported-by: Linus Torvalds <>
> Suggested-by: Linus Torvalds <>
> Signed-off-by: Oleg Nesterov <>

Thanks Oleg.

Looks good to me.

Reviewed-by: Srikar Dronamraju <>
> ---

Thanks and Regards
Srikar Dronamraju

Powered by blists - more mailing lists