linux-kernel - Re: [PATCH v4 08/10] loop: Rework lo_ioctl() _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200506060741.GE10771@lst.de>
Date:   Wed, 6 May 2020 08:07:41 +0200
From:   Christoph Hellwig <hch@....de>
To:     Martijn Coenen <maco@...roid.com>
Cc:     axboe@...nel.dk, hch@....de, ming.lei@...hat.com,
        narayan@...gle.com, zezeozue@...gle.com, kernel-team@...roid.com,
        maco@...gle.com, bvanassche@....org, Chaitanya.Kulkarni@....com,
        jaegeuk@...nel.org, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 08/10] loop: Rework lo_ioctl() __user argument
 casting

On Wed, Apr 29, 2020 at 04:03:39PM +0200, Martijn Coenen wrote:
> In preparation for a new ioctl that needs to copy_from_user(); makes the
> code easier to read as well.
> 
> Signed-off-by: Martijn Coenen <maco@...roid.com>

Looks good,

Reviewed-by: Christoph Hellwig <hch@....de>

Btw, it seems like you have dropped all the reviews from the previous
versions, even if nothing substantial changed.  Please keep them unless
a patch actually is reworked.