lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 5 May 2020 17:00:05 -0700 From: Atish Patra <atishp@...shpatra.org> To: Palmer Dabbelt <palmer@...belt.com> Cc: Atish Patra <Atish.Patra@....com>, Albert Ou <aou@...s.berkeley.edu>, Anup Patel <Anup.Patel@....com>, "linux-kernel@...r.kernel.org List" <linux-kernel@...r.kernel.org>, Zong Li <zong.li@...ive.com>, Paul Walmsley <paul.walmsley@...ive.com>, linux-riscv <linux-riscv@...ts.infradead.org> Subject: Re: [PATCH] RISC-V: Remove unused code from STRICT_KERNEL_RWX On Tue, May 5, 2020 at 4:55 PM Palmer Dabbelt <palmer@...belt.com> wrote: > > On Sun, 03 May 2020 21:03:19 PDT (-0700), Atish Patra wrote: > > This patch removes the unused functions set_kernel_text_rw/ro. > > Currently, it is not being invoked from anywhere and no other architecture > > (except arm) uses this code. Even in ARM, these functions are not invoked > > from anywhere currently. > > > > Fixes: d27c3c90817e ("riscv: add STRICT_KERNEL_RWX support") > > > > Signed-off-by: Atish Patra <atish.patra@....com> > > --- > > arch/riscv/mm/init.c | 16 ---------------- > > 1 file changed, 16 deletions(-) > > > > diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c > > index b55be44ff9bd..ba60a581e9b6 100644 > > --- a/arch/riscv/mm/init.c > > +++ b/arch/riscv/mm/init.c > > @@ -501,22 +501,6 @@ static inline void setup_vm_final(void) > > #endif /* CONFIG_MMU */ > > > > #ifdef CONFIG_STRICT_KERNEL_RWX > > -void set_kernel_text_rw(void) > > -{ > > - unsigned long text_start = (unsigned long)_text; > > - unsigned long text_end = (unsigned long)_etext; > > - > > - set_memory_rw(text_start, (text_end - text_start) >> PAGE_SHIFT); > > -} > > - > > -void set_kernel_text_ro(void) > > -{ > > - unsigned long text_start = (unsigned long)_text; > > - unsigned long text_end = (unsigned long)_etext; > > - > > - set_memory_ro(text_start, (text_end - text_start) >> PAGE_SHIFT); > > -} > > - > > void mark_rodata_ro(void) > > { > > unsigned long text_start = (unsigned long)_text; > > Thanks, this is on fixes. Are you going to remove the ARM code as well? > Yeah and also I realized that I forgot to remove the declarations from the header file. My bad. I will send out a v2. Please drop this one and take v2. -- Regards, Atish
Powered by blists - more mailing lists