linux-kernel - Re: [PATCH] serial: lantiq: Add x86 in Kconfig dependencies for Lantiq serial driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 6 May 2020 08:41:48 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     "Tanwar, Rahul" <rahul.tanwar@...ux.intel.com>
Cc:     linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
        andriy.shevchenko@...el.com
Subject: Re: [PATCH] serial: lantiq: Add x86 in Kconfig dependencies for
 Lantiq serial driver

On Wed, May 06, 2020 at 12:49:57PM +0800, Tanwar, Rahul wrote:
> 
> On 5/5/2020 10:25 pm, Greg KH wrote:
> > On Mon, May 04, 2020 at 04:03:52PM +0800, Rahul Tanwar wrote:
> >> Lantiq serial driver/IP is reused for a x86 based SoC as well.
> >> Update the Kconfig accordingly.
> >>
> >> Signed-off-by: Rahul Tanwar <rahul.tanwar@...ux.intel.com>
> >> ---
> >>  drivers/tty/serial/Kconfig | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> >> index 0aea76cd67ff..4b0a7b98f8c7 100644
> >> --- a/drivers/tty/serial/Kconfig
> >> +++ b/drivers/tty/serial/Kconfig
> >> @@ -1035,7 +1035,7 @@ config SERIAL_SIFIVE_CONSOLE
> >>  
> >>  config SERIAL_LANTIQ
> >>  	bool "Lantiq serial driver"
> >> -	depends on LANTIQ
> >> +	depends on (LANTIQ || X86) || COMPILE_TEST
> >>  	select SERIAL_CORE
> >>  	select SERIAL_CORE_CONSOLE
> >>  	select SERIAL_EARLYCON
> >> -- 
> >> 2.11.0
> >>
> > Any reason this can't also be a module?
> 
> Thanks a lot for accepting the patch. This driver is also used for
> console during bootup so we always have it as built in.

So no generic kernel images can ever be made for this driver?  That's
not good, what about systems that have this serial port but does not
care about the console?

That's just ensuring that it will not be built into any distro kernel
images, I suggest fixing this up please.

thanks,

greg k-h