linux-kernel - Re: [PATCH -next] vdpasim: remove unused variable 'ret'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 5 May 2020 20:35:58 -0400
From:   "Michael S. Tsirkin" <mst@...hat.com>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     jasowang@...hat.com, virtualization@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] vdpasim: remove unused variable 'ret'

On Fri, Apr 10, 2020 at 07:54:22PM +0800, YueHaibing wrote:
> drivers/vdpa/vdpa_sim/vdpa_sim.c:92:6: warning:
>  variable ‘ret’ set but not used [-Wunused-but-set-variable]
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---

Either this, or BUG_ON.  Jason?

>  drivers/vdpa/vdpa_sim/vdpa_sim.c | 15 +++++++--------
>  1 file changed, 7 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa/vdpa_sim/vdpa_sim.c
> index 7957d2d41fc4..01c456f7c1f7 100644
> --- a/drivers/vdpa/vdpa_sim/vdpa_sim.c
> +++ b/drivers/vdpa/vdpa_sim/vdpa_sim.c
> @@ -89,15 +89,14 @@ static struct vdpasim *dev_to_sim(struct device *dev)
>  static void vdpasim_queue_ready(struct vdpasim *vdpasim, unsigned int idx)
>  {
>  	struct vdpasim_virtqueue *vq = &vdpasim->vqs[idx];
> -	int ret;
>  
> -	ret = vringh_init_iotlb(&vq->vring, vdpasim_features,
> -				VDPASIM_QUEUE_MAX, false,
> -				(struct vring_desc *)(uintptr_t)vq->desc_addr,
> -				(struct vring_avail *)
> -				(uintptr_t)vq->driver_addr,
> -				(struct vring_used *)
> -				(uintptr_t)vq->device_addr);
> +	vringh_init_iotlb(&vq->vring, vdpasim_features,
> +			  VDPASIM_QUEUE_MAX, false,
> +			  (struct vring_desc *)(uintptr_t)vq->desc_addr,
> +			  (struct vring_avail *)
> +			  (uintptr_t)vq->driver_addr,
> +			  (struct vring_used *)
> +			  (uintptr_t)vq->device_addr);
>  }
>  
>  static void vdpasim_vq_reset(struct vdpasim_virtqueue *vq)
> -- 
> 2.17.1
>