linux-kernel - Re: [PATCH v4 1/9] w1_therm: creating w1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56b06ae0d110d650e65e4ed72fd44f870997893f.camel@gmail.com>
Date:   Wed, 06 May 2020 12:43:31 +0200
From:   Akira shimahara <akira215corp@...il.com>
To:     Greg KH <greg@...ah.com>
Cc:     zbr@...emap.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/9] w1_therm: creating w1_therm.h

Le mercredi 06 mai 2020 à 08:51 +0200, Greg KH a écrit :
> > > Why is this function needed to be declared in this .h file?
> > > Why is any of this needed?  For some reason I thought you needed
> > > a .h
> > > file to make things simpler for other .c files, but if all of
> > > this is
> > > static, it's not needed at all, right?
> > > thanks,
> > > greg k-h
> > Hello,
> > Yes, you are right, header file could be avoided. But we separate
> > it
> > from .c for clarity purpose, and to ease future developpment (for
> > example adding support of new devices).
> > If you absolutely want to put everything in the .c file, I can do
> > it,
> > let me know.
> 
> 
> Keep it all in a .c file, only use .h files for when you need to
> share
> 
> it across multiple .c files, otherwise it's not needed.
> 
> 
> 
> thanks,
> 
> 
> 
> greg k-h

Hi, 

Ok well noted, I will do it tomorrow, and keep it as 8 patches.

Thanks for your time

Akira Shimahara