linux-kernel - RE: [PATCH -next] firmware: imx: scu: Fix possible memory leak in imx_scu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM6PR04MB4966951644D380842EA80D9180A40@AM6PR04MB4966.eurprd04.prod.outlook.com>
Date:   Wed, 6 May 2020 11:02:57 +0000
From:   Aisheng Dong <aisheng.dong@....com>
To:     Wei Yongjun <weiyongjun1@...wei.com>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        dl-linux-imx <linux-imx@....com>
CC:     "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: RE: [PATCH -next] firmware: imx: scu: Fix possible memory leak in
 imx_scu_probe()

> From: Wei Yongjun <weiyongjun1@...wei.com>
> Sent: Wednesday, May 6, 2020 1:14 PM
> 
> 'chan_name' is malloced in imx_scu_probe() and should be freed before leaving
> from the error handling cases, otherwise it will cause memory leak.
> 
> Fixes: edbee095fafb ("firmware: imx: add SCU firmware driver support")
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>

Thanks for the fix.
Reviewed-by: Dong Aisheng <aisheng.dong@....com>

Regards
Aisheng