linux-kernel - Re: [PATCH] fs: kernfs: fix possible null pointer dereferences

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 6 May 2020 14:44:07 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     youngjun <her0gyugyu@...il.com>
Cc:     Tejun Heo <tj@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs: kernfs: fix possible null pointer dereferences

On Thu, Apr 30, 2020 at 04:20:46AM -0700, youngjun wrote:
> kernfs_path_from_node_locked checks buf is NULL.
> But, two cases below are not covered.
> 
> if(!kn_to)			<--- case1 (buf can be NULL)
> 	return strlcpy(buf, "(null)", buflen);
> 
> if(kn_from == kn_to)		<--- case2 (buf can be NULL)
> 	return strlcpy(buf, "/", buflen);
> 
> if (!buf)			<--- checked here.
> 	return -EINVAL;
> 
> buf NULL case needs to be checked first.
> 
> Signed-off-by: youngjun <her0gyugyu@...il.com>
> ---
>  fs/kernfs/dir.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

I have 3 patches here from you, with the same subject lines, yet they do
different things.

I'm dropping them all, can you please resend a patch series of the
remaining patches you wish us to review for kernfs?

thanks,

greg k-h