[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAAOTY_9Cuc40zaDF83m7sJiok35x3oqDCr4JQRJyvLCBZ4U_FA@mail.gmail.com>
Date: Wed, 6 May 2020 21:01:32 +0800
From: Chun-Kuang Hu <chunkuang.hu@...nel.org>
To: Bernard Zhao <bernard@...o.com>
Cc: Chun-Kuang Hu <chunkuang.hu@...nel.org>,
Philipp Zabel <p.zabel@...gutronix.de>,
David Airlie <airlied@...ux.ie>,
Daniel Vetter <daniel@...ll.ch>,
Matthias Brugger <matthias.bgg@...il.com>,
DRI Development <dri-devel@...ts.freedesktop.org>,
Linux ARM <linux-arm-kernel@...ts.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@...ts.infradead.org>,
linux-kernel <linux-kernel@...r.kernel.org>,
opensource.kernel@...o.com
Subject: Re: [PATCH v2] drm/mediatek: cleanup coding style in mediatek a bit
Hi, Bernard:
Bernard Zhao <bernard@...o.com> 於 2020年5月6日 週三 下午8:34寫道:
>
> This code change is to make code bit more readable.
>
Reviewed-by: Chun-Kuang Hu <chunkuang.hu@...nel.org>
> Signed-off-by: Bernard Zhao <bernard@...o.com>
> ---
> drivers/gpu/drm/mediatek/mtk_hdmi.c | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> index ff43a3d80410..43e9876fd50c 100644
> --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> @@ -311,14 +311,10 @@ static void mtk_hdmi_hw_send_info_frame(struct mtk_hdmi *hdmi, u8 *buffer,
> u8 checksum;
> int ctrl_frame_en = 0;
>
> - frame_type = *buffer;
> - buffer += 1;
> - frame_ver = *buffer;
> - buffer += 1;
> - frame_len = *buffer;
> - buffer += 1;
> - checksum = *buffer;
> - buffer += 1;
> + frame_type = *buffer++;
> + frame_ver = *buffer++;
> + frame_len = *buffer++;
> + checksum = *buffer++;
> frame_data = buffer;
>
> dev_dbg(hdmi->dev,
> --
> 2.26.2
>
Powered by blists - more mailing lists