linux-kernel - Re: [PATCH -next] ipack: tpci200: fix error return code in tpci200

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eaaa54dbe413bf3f13f08c267e6c31c497afb509.camel@igalia.com>
Date:   Thu, 07 May 2020 16:34:06 +0200
From:   Samuel Iglesias Gonsálvez 
        <siglesias@...lia.com>
To:     Wei Yongjun <weiyongjun1@...wei.com>,
        Jens Taprogge <jens.taprogge@...rogge.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Zhouyang Jia <jiazhouyang09@...il.com>,
        Kees Cook <keescook@...omium.org>
Cc:     industrypack-devel@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Hulk Robot <hulkci@...wei.com>
Subject: Re: [PATCH -next] ipack: tpci200: fix error return code in
 tpci200_register()

Hello Wei,

Thanks for the patch!

Patch is,

Acked-by: Samuel Iglesias Gonsalvez <siglesias@...lia.com>

Greg, Would you mind picking this patch series through your char-misc
tree?

Thanks!

Sam

On Thu, 2020-05-07 at 09:42 +0000, Wei Yongjun wrote:
> Fix to return negative error code -ENOMEM from the ioremap() error
> handling
> case instead of 0, as done elsewhere in this function.
> 
> Fixes: 43986798fd50 ("ipack: add error handling for ioremap_nocache")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
> ---
>  drivers/ipack/carriers/tpci200.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/ipack/carriers/tpci200.c
> b/drivers/ipack/carriers/tpci200.c
> index 8a9c169..b5eec18 100644
> --- a/drivers/ipack/carriers/tpci200.c
> +++ b/drivers/ipack/carriers/tpci200.c
> @@ -309,6 +309,7 @@ static int tpci200_register(struct tpci200_board
> *tpci200)
>  			"(bn 0x%X, sn 0x%X) failed to map driver user
> space!",
>  			tpci200->info->pdev->bus->number,
>  			tpci200->info->pdev->devfn);
> +		res = -ENOMEM;
>  		goto out_release_mem8_space;
>  	}
> 
> 
> 
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)