linux-kernel - Re: [PATCH next] ARM: dts: am437x: fix networking on boards with ksz9031 phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 7 May 2020 18:13:24 +0300
From:   Grygorii Strashko <grygorii.strashko@...com>
To:     Oleksij Rempel <o.rempel@...gutronix.de>
CC:     Tony Lindgren <tony@...mide.com>,
        "David S. Miller" <davem@...emloft.net>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-omap@...r.kernel.org>,
        Andrew Lunn <andrew@...n.ch>,
        Philippe Schenker <philippe.schenker@...adex.com>
Subject: Re: [PATCH next] ARM: dts: am437x: fix networking on boards with
 ksz9031 phy



On 07/05/2020 07:40, Oleksij Rempel wrote:
> Hi Grygorii,
> 
> thank you for you patches!
> 
> On Wed, May 06, 2020 at 10:08:35PM +0300, Grygorii Strashko wrote:
>> Since commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the
>> KSZ9031 PHY") the networking is broken on boards:
>>   am437x-gp-evm
>>   am437x-sk-evm
>>   am437x-idk-evm
>>
>> All above boards have phy-mode = "rgmii" and this is worked before, because
>> KSZ9031 PHY started with default RGMII internal delays configuration (TX
>> off, RX on 1.2 ns) and MAC provided TX delay. After above commit, the
>> KSZ9031 PHY starts handling phy mode properly and disables RX delay, as
>> result networking is become broken.
>>
>> Fix it by switching to phy-mode = "rgmii-rxid" to reflect previous
>> behavior.
>>
>> Cc: Oleksij Rempel <o.rempel@...gutronix.de>
>> Cc: Andrew Lunn <andrew@...n.ch>
>> Cc: Philippe Schenker <philippe.schenker@...adex.com>
>> Fixes: commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the KSZ9031 PHY")
>> Signed-off-by: Grygorii Strashko <grygorii.strashko@...com>
>> ---
>>   arch/arm/boot/dts/am437x-gp-evm.dts  | 2 +-
>>   arch/arm/boot/dts/am437x-idk-evm.dts | 2 +-
>>   arch/arm/boot/dts/am437x-sk-evm.dts  | 4 ++--
>>   3 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/am437x-gp-evm.dts b/arch/arm/boot/dts/am437x-gp-evm.dts
>> index 811c8cae315b..d692e3b2812a 100644
>> --- a/arch/arm/boot/dts/am437x-gp-evm.dts
>> +++ b/arch/arm/boot/dts/am437x-gp-evm.dts
>> @@ -943,7 +943,7 @@
>>   
>>   &cpsw_emac0 {
>>   	phy-handle = <&ethphy0>;
>> -	phy-mode = "rgmii";
>> +	phy-mode = "rgmii-rxid";
>>   };
>>   
>>   &elm {
>> diff --git a/arch/arm/boot/dts/am437x-idk-evm.dts b/arch/arm/boot/dts/am437x-idk-evm.dts
>> index 9f66f96d09c9..a7495fb364bf 100644
>> --- a/arch/arm/boot/dts/am437x-idk-evm.dts
>> +++ b/arch/arm/boot/dts/am437x-idk-evm.dts
>> @@ -504,7 +504,7 @@
>>   
>>   &cpsw_emac0 {
>>   	phy-handle = <&ethphy0>;
>> -	phy-mode = "rgmii";
>> +	phy-mode = "rgmii-id";
>>   };
> 
> Do you have here really rgmii-id?
> 

Right, thanks you.

-- 
Best regards,
grygorii