linux-kernel - Re: [PATCH 1/1] s390/dasd: remove ioctl_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 7 May 2020 17:45:54 +0200
From:   Christoph Hellwig <hch@....de>
To:     Stefan Haberland <sth@...ux.ibm.com>
Cc:     Christoph Hellwig <hch@....de>, axboe@...nel.dk,
        linux-block@...r.kernel.org, hoeppner@...ux.ibm.com,
        linux-s390@...r.kernel.org, heiko.carstens@...ibm.com,
        gor@...ux.ibm.com, borntraeger@...ibm.com,
        linux-kernel@...r.kernel.org,
        Peter Oberparleiter <oberpar@...ux.ibm.com>
Subject: Re: [PATCH 1/1] s390/dasd: remove ioctl_by_bdev from DASD driver

On Thu, May 07, 2020 at 05:43:40PM +0200, Stefan Haberland wrote:
> Not checked till now. I just was thinking about the basicapproach.
> 
> I could either check the block_device_operations like you suggested
> or I could verify that the gendisk pointer is already in our devmap
> and therefor belongs to the DASD driver.

The ops pointer check is simpler and cheaper, so I'd suggest that.