linux-kernel - Re: [PATCH v2 12/45] powerpc/ptdump: Properly handle non standard page size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202005080012.RtDztvo7%lkp@intel.com>
Date:   Fri, 8 May 2020 00:12:31 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Christophe Leroy <christophe.leroy@...roup.eu>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>,
        Michael Ellerman <mpe@...erman.id.au>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH v2 12/45] powerpc/ptdump: Properly handle non standard
 page size

Hi Christophe,

I love your patch! Yet something to improve:

[auto build test ERROR on v5.7-rc4]
[cannot apply to powerpc/next next-20200507]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Christophe-Leroy/Use-hugepages-to-map-kernel-mem-on-8xx/20200507-060838
base:    0e698dfa282211e414076f9dc7e83c1c288314fd
config: powerpc-randconfig-r013-20200507 (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=powerpc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   arch/powerpc/mm/ptdump/ptdump.c: In function 'walk_pmd':
>> arch/powerpc/mm/ptdump/ptdump.c:285:42: error: 'PTE_SHIFT' undeclared (first use in this function); did you mean 'PUD_SHIFT'?
     285 |    note_page(st, addr, 3, pmd_val(*pmd), PTE_SHIFT);
         |                                          ^~~~~~~~~
         |                                          PUD_SHIFT
   arch/powerpc/mm/ptdump/ptdump.c:285:42: note: each undeclared identifier is reported only once for each function it appears in

vim +285 arch/powerpc/mm/ptdump/ptdump.c

   272	
   273	static void walk_pmd(struct pg_state *st, pud_t *pud, unsigned long start)
   274	{
   275		pmd_t *pmd = pmd_offset(pud, 0);
   276		unsigned long addr;
   277		unsigned int i;
   278	
   279		for (i = 0; i < PTRS_PER_PMD; i++, pmd++) {
   280			addr = start + i * PMD_SIZE;
   281			if (!pmd_none(*pmd) && !pmd_is_leaf(*pmd))
   282				/* pmd exists */
   283				walk_pte(st, pmd, addr);
   284			else
 > 285				note_page(st, addr, 3, pmd_val(*pmd), PTE_SHIFT);
   286		}
   287	}
   288	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (25682 bytes)