linux-kernel - Re: [PATCH 1/2] perf: Fix POWER9 metric 'lsu_other_stall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200507164825.GE31109@kernel.org>
Date:   Thu, 7 May 2020 13:48:25 -0300
From:   Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
To:     "Paul A. Clarke" <pc@...ibm.com>
Cc:     linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
        ananth@...ux.vnet.ibm.com, maddy@...ux.vnet.ibm.com,
        naveen.n.rao@...ux.vnet.ibm.com, sukadev@...ux.ibm.com,
        mpe@...erman.id.au, irogers@...gle.com
Subject: Re: [PATCH 1/2] perf: Fix POWER9 metric 'lsu_other_stall_cpi'

Em Thu, May 07, 2020 at 11:28:57AM -0500, Paul A. Clarke escreveu:
> From: "Paul A. Clarke" <pc@...ibm.com>
> 
> The metric definition is too long for the current value of EXPR_MAX_OTHER.
> Increase the value EXPR_MAX_OTHER sufficiently to allow
> 'lsu_other_stall_cpi' to build properly.

I already have a patch from Ian that bumps this further:

[acme@...e perf]$ git log -p tools/perf/util/expr.h
commit 26d3350db3e4668c1b1ff7f81c419afe71a2e8d9
Author: Ian Rogers <irogers@...gle.com>
Date:   Fri May 1 10:33:26 2020 -0700

    perf expr: Increase max other

    Large metrics such as Branch_Misprediction_Cost_SMT on x86 broadwell
    need more space.

    Signed-off-by: Ian Rogers <irogers@...gle.com>
    Acked-by: Jiri Olsa <jolsa@...hat.com>
    Cc: Adrian Hunter <adrian.hunter@...el.com>
    Cc: Alexander Shishkin <alexander.shishkin@...ux.intel.com>
    Cc: Andi Kleen <ak@...ux.intel.com>
    Cc: Haiyan Song <haiyanx.song@...el.com>
    Cc: Jin Yao <yao.jin@...ux.intel.com>
    Cc: John Garry <john.garry@...wei.com>
    Cc: Kajol Jain <kjain@...ux.ibm.com>
    Cc: Kan Liang <kan.liang@...ux.intel.com>
    Cc: Leo Yan <leo.yan@...aro.org>
    Cc: Mark Rutland <mark.rutland@....com>
    Cc: Namhyung Kim <namhyung@...nel.org>
    Cc: Paul Clarke <pc@...ibm.com>
    Cc: Peter Zijlstra <peterz@...radead.org>
    Cc: Ravi Bangoria <ravi.bangoria@...ux.ibm.com>
    Cc: Song Liu <songliubraving@...com>
    Cc: Stephane Eranian <eranian@...gle.com>
    Link: http://lore.kernel.org/lkml/20200501173333.227162-6-irogers@google.com
    Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>

diff --git a/tools/perf/util/expr.h b/tools/perf/util/expr.h
index 87d627bb699b..40fc452b0f2b 100644
--- a/tools/perf/util/expr.h
+++ b/tools/perf/util/expr.h
@@ -2,7 +2,7 @@
 #ifndef PARSE_CTX_H
 #define PARSE_CTX_H 1

-#define EXPR_MAX_OTHER 20
+#define EXPR_MAX_OTHER 64
 #define MAX_PARSE_ID EXPR_MAX_OTHER

 struct expr_parse_id {

 
> Before:
> --
> $ perf list | grep lsu_other
>   lsu_other_stall_cpi
> # perf stat -a --metrics lsu_other_stall_cpi /bin/sleep 1
> Cannot find metric or group `lsu_other_stall_cpi'
> 
>  Usage: perf stat [<options>] [<command>]
> 
>     -M, --metrics <metric/metric group list>
>                           monitor specified metrics or metric groups (separated by ,)
> --
> 
> After:
> --
> # perf stat -a --metrics lsu_other_stall_cpi /bin/sleep 1
> 
>  Performance counter stats for 'system wide':
> 
>        438,086,889      pm_cmplu_stall_lsu        #     1.74 lsu_other_stall_cpi
> [...]
> --
> 
> Signed-off-by: Paul A. Clarke <pc@...ibm.com>
> ---
>  tools/perf/util/expr.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/expr.h b/tools/perf/util/expr.h
> index 87d627bb699b..a0991959cca4 100644
> --- a/tools/perf/util/expr.h
> +++ b/tools/perf/util/expr.h
> @@ -2,7 +2,7 @@
>  #ifndef PARSE_CTX_H
>  #define PARSE_CTX_H 1
>  
> -#define EXPR_MAX_OTHER 20
> +#define EXPR_MAX_OTHER 28
>  #define MAX_PARSE_ID EXPR_MAX_OTHER
>  
>  struct expr_parse_id {
> -- 
> 2.18.2
> 

-- 

- Arnaldo