linux-kernel - Re: [PATCH] wcn36xx: Fix error handling path in wcn36xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <874ksr4oyn.fsf@codeaurora.org>
Date:   Thu, 07 May 2020 20:47:12 +0300
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Markus Elfring <Markus.Elfring@....de>
Cc:     Christophe Jaillet <christophe.jaillet@...adoo.fr>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        wcn36xx@...ts.infradead.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org, Andy Gross <andy.gross@...aro.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        "David S. Miller" <davem@...emloft.net>,
        Marcel Holtmann <marcel@...tmann.org>
Subject: Re: [PATCH] wcn36xx: Fix error handling path in wcn36xx_probe()

Markus Elfring <Markus.Elfring@....de> writes:

> …
>> +++ b/drivers/net/wireless/ath/wcn36xx/main.c
> …
>> @@ -1359,6 +1359,8 @@ static int wcn36xx_probe(struct platform_device *pdev)
>>  out_unmap:
>>  	iounmap(wcn->ccu_base);
>>  	iounmap(wcn->dxe_base);
>> +out_channel:
>> +	rpmsg_destroy_ept(wcn->smd_channel);
>>  out_wq:
>>  	ieee80211_free_hw(hw);
>>  out_err:
>
> How do you think about to use the label “out_destroy_ept”?

Yeah, that's better. I'll change it in the pending branch before I
commit.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches