linux-kernel - Re: [PATCH next] ARM: dts: am57xx: fix networking on boards with ksz9031 phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200507175158.GW37466@atomide.com>
Date:   Thu, 7 May 2020 10:51:58 -0700
From:   Tony Lindgren <tony@...mide.com>
To:     Philippe Schenker <philippe.schenker@...adex.com>
Cc:     "davem@...emloft.net" <davem@...emloft.net>,
        "grygorii.strashko@...com" <grygorii.strashko@...com>,
        "o.rempel@...gutronix.de" <o.rempel@...gutronix.de>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
        "andrew@...n.ch" <andrew@...n.ch>
Subject: Re: [PATCH next] ARM: dts: am57xx: fix networking on boards with
 ksz9031 phy

* Philippe Schenker <philippe.schenker@...adex.com> [200507 08:43]:
> On Wed, 2020-05-06 at 22:11 +0300, Grygorii Strashko wrote:
> > Since commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for
> > the
> > KSZ9031 PHY") the networking is broken on boards:
> >  am571x-idk
> >  am572x-idk
> >  am574x-idk
> >  am57xx-beagle-x15
> > 
> > All above boards have phy-mode = "rgmii" and this is worked before
> > because
> > KSZ9031 PHY started with default RGMII internal delays configuration
> > (TX
> > off, RX on 1.2 ns) and MAC provided TX delay. After above commit, the
> > KSZ9031 PHY starts handling phy mode properly and disables RX delay,
> > as
> > result networking is become broken.
> > 
> > Fix it by switching to phy-mode = "rgmii-rxid" to reflect previous
> > behavior.
> > 
> > Cc: Oleksij Rempel <o.rempel@...gutronix.de>
> > Cc: Andrew Lunn <andrew@...n.ch>
> > Cc: Philippe Schenker <philippe.schenker@...adex.com>
> > Fixes: commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support
> > for the KSZ9031 PHY")
> > Signed-off-by: Grygorii Strashko <grygorii.strashko@...com>
> 
> Thanks Grygorii!
> 
> Reviewed-by: Philippe Schenker <
> philippe.schenker@...adex.com>

Thanks applying this into fixes.

Tony