linux-kernel - Re: [PATCH net-next] net: tulip: de4x5: make PCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200507.130438.579883511397409999.davem@davemloft.net>
Date:   Thu, 07 May 2020 13:04:38 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     yanaijie@...wei.com
Cc:     netdev@...r.kernel.org, linux-parisc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: tulip: de4x5: make PCI_signature()
 return void

From: Jason Yan <yanaijie@...wei.com>
Date: Thu, 7 May 2020 19:08:47 +0800

> This function always return 0 now, we can make it return void to
> simplify the code. This fixes the following coccicheck warning:
> 
> drivers/net/ethernet/dec/tulip/de4x5.c:3908:11-17: Unneeded variable:
> "status". Return "0" on line 3912
> 
> Signed-off-by: Jason Yan <yanaijie@...wei.com>

Applied.