linux-kernel - Re: [PATCH v1] Add support for MediaTek regulator vibrator driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49089bf3-d64b-2a50-269c-623a6ea9c14c@gmail.com>
Date:   Thu, 7 May 2020 22:45:35 +0200
From:   Jacek Anaszewski <jacek.anaszewski@...il.com>
To:     Pavel Machek <pavel@....cz>, Xing Zhang <Xing.Zhang@...iatek.com>
Cc:     Matthias Brugger <matthias.bgg@...il.com>,
        Dan Murphy <dmurphy@...com>,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-leds@...r.kernel.org
Subject: Re: [PATCH v1] Add support for MediaTek regulator vibrator driver

Hi Pavel,

On 5/7/20 7:45 PM, Pavel Machek wrote:
> Hi!
> 
>> This patchset add regulator vibrator driver for MTK Soc. The driver
>> controls vibrator through regulator's enable and disable.
> 
> We'd prefer not to have vibrators in led subsystem.
> 
>>
>> Xing Zhang (3):
>>    dt-bindings: add regulator vibrator documentation
>>    arm64: mediatek: Add regulator vibrator support
>>    Vibrator: Add regulator vibrator driver
>>
>>   .../bindings/leds/regulator-vibrator.txt      |  39 ++
>>   arch/arm64/configs/defconfig                  |   1 +
>>   drivers/leds/Kconfig                          |  10 +
>>   drivers/leds/Makefile                         |   1 +
>>   drivers/leds/regulator-vibrator.c             | 450 ++++++++++++++++++
> 
> OTOH, connecting LED to regulator might make some sense. I can take the driver with
> vibrator functionality stripped, provided it is named the usual way...

We already had an attempt of solving this in more generic way [0],
but you opposed then [1]. Just for the record.

[0] 
https://lore.kernel.org/linux-leds/20170913175400.42744-1-dtwlin@google.com/
[1] https://lore.kernel.org/linux-leds/20170914205804.GA24339@amd/

-- 
Best regards,
Jacek Anaszewski