linux-kernel - Re: [PATCH] tracing/probe: reverse arguments to list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200507165239.0264de30@gandalf.local.home>
Date:   Thu, 7 May 2020 16:52:39 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Julia Lawall <Julia.Lawall@...ia.fr>
Cc:     kernel-janitors@...r.kernel.org, Ingo Molnar <mingo@...hat.com>,
        linux-kernel@...r.kernel.org,
        Nic Volanschi <eugene.volanschi@...ia.fr>,
        Masami Hiramatsu <mhiramat@...nel.org>
Subject: Re: [PATCH] tracing/probe: reverse arguments to list_add

On Thu, 7 May 2020 16:50:53 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:

> On Thu,  7 May 2020 21:30:08 +0200
> Julia Lawall <Julia.Lawall@...ia.fr> wrote:
> 
> > Elsewhere in the file, the function trace_kprobe_has_same_kprobe uses
> > a trace_probe_event.probes object as the second argument of
> > list_for_each_entry, ie as a list head, while the list_for_each_entry
> > iterates over the list fields of the trace_probe structures, making
> > them the list elements.  So, exchange the arguments on the list_add
> > call to put the list head in the second argument.
> > 
> > Since both list_head structures were just initialized, this problem
> > did not cause any loss of information.
> > 
> > Fixes: 60d53e2c3b75 ("tracing/probe: Split trace_event related data from trace_probe")
> > Signed-off-by: Julia Lawall <Julia.Lawall@...ia.fr>  
> 

Julia,

As this doesn't cause any harm (as you state, both lists have just been
initialized), it doesn't need to go into this -rc release. Would you agree?

-- Steve