linux-kernel - Re: [PATCH 1/1] Smack:- Remove redundant inode_smack cache since now new cache is being used for inode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7edd3a52-7f9a-11e6-2300-714b28d163ca@schaufler-ca.com>
Date:   Thu, 7 May 2020 15:26:35 -0700
From:   Casey Schaufler <casey@...aufler-ca.com>
To:     Vishal Goel <vishal.goel@...sung.com>,
        linux-security-modulemodule@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] Smack:- Remove redundant inode_smack cache since now
 new cache is being used for inode_smack structure allocations

On 4/26/2020 9:12 PM, Vishal Goel wrote:
> Signed-off-by: Vishal Goel <vishal.goel@...sung.com>

I've taken this after adding a commit message.
Please include a commit message, even if you believe
the "subject line says it all" in the future.

> ---
>  security/smack/smack_lsm.c | 9 +--------
>  1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
> index 2862fc3..d0f87d4 100644
> --- a/security/smack/smack_lsm.c
> +++ b/security/smack/smack_lsm.c
> @@ -55,7 +55,6 @@
>  DEFINE_MUTEX(smack_ipv6_lock);
>  static LIST_HEAD(smk_ipv6_port_list);
>  #endif
> -static struct kmem_cache *smack_inode_cache;
>  struct kmem_cache *smack_rule_cache;
>  int smack_enabled;
>  
> @@ -4841,15 +4840,9 @@ static __init int smack_init(void)
>  	struct cred *cred = (struct cred *) current->cred;
>  	struct task_smack *tsp;
>  
> -	smack_inode_cache = KMEM_CACHE(inode_smack, 0);
> -	if (!smack_inode_cache)
> -		return -ENOMEM;
> -
>  	smack_rule_cache = KMEM_CACHE(smack_rule, 0);
> -	if (!smack_rule_cache) {
> -		kmem_cache_destroy(smack_inode_cache);
> +	if (!smack_rule_cache)
>  		return -ENOMEM;
> -	}
>  
>  	/*
>  	 * Set the security state for the initial task.