lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 7 May 2020 12:03:04 +0200 From: Nicolas Ferre <nicolas.ferre@...rochip.com> To: Jakub Kicinski <kuba@...nel.org>, <netdev@...r.kernel.org>, "David S. Miller" <davem@...emloft.net> CC: <linux-arm-kernel@...ts.infradead.org>, Claudiu Beznea <claudiu.beznea@...rochip.com>, <harini.katakam@...inx.com>, <linux-kernel@...r.kernel.org>, Alexandre Belloni <alexandre.belloni@...tlin.com>, <antoine.tenart@...tlin.com>, <f.fainelli@...il.com> Subject: Re: [PATCH v4 1/5] net: macb: fix wakeup test in runtime suspend/resume routines On 06/05/2020 at 22:18, Jakub Kicinski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On Wed, 6 May 2020 13:37:37 +0200 nicolas.ferre@...rochip.com wrote: >> From: Nicolas Ferre <nicolas.ferre@...rochip.com> >> >> Use the proper struct device pointer to check if the wakeup flag >> and wakeup source are positioned. >> Use the one passed by function call which is equivalent to >> &bp->dev->dev.parent. >> >> It's preventing the trigger of a spurious interrupt in case the >> Wake-on-Lan feature is used. >> >> Fixes: bc1109d04c39 ("net: macb: Add pm runtime support") > > Fixes tag: Fixes: bc1109d04c39 ("net: macb: Add pm runtime support") > Has these problem(s): > - Target SHA1 does not exist Indeed, it's: Fixes: d54f89af6cc4 ("net: macb: Add pm runtime support") David: do I have to respin or you can modify it? Thanks. Regards, Nicolas >> Signed-off-by: Nicolas Ferre <nicolas.ferre@...rochip.com> >> Reviewed-by: Florian Fainelli <f.fainelli@...il.com> >> Cc: Claudiu Beznea <claudiu.beznea@...rochip.com> >> Cc: Harini Katakam <harini.katakam@...inx.com> >> --- >> drivers/net/ethernet/cadence/macb_main.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c >> index 36290a8e2a84..d11fae37d46b 100644 >> --- a/drivers/net/ethernet/cadence/macb_main.c >> +++ b/drivers/net/ethernet/cadence/macb_main.c >> @@ -4616,7 +4616,7 @@ static int __maybe_unused macb_runtime_suspend(struct device *dev) >> struct net_device *netdev = dev_get_drvdata(dev); >> struct macb *bp = netdev_priv(netdev); >> >> - if (!(device_may_wakeup(&bp->dev->dev))) { >> + if (!(device_may_wakeup(dev))) { >> clk_disable_unprepare(bp->tx_clk); >> clk_disable_unprepare(bp->hclk); >> clk_disable_unprepare(bp->pclk); >> @@ -4632,7 +4632,7 @@ static int __maybe_unused macb_runtime_resume(struct device *dev) >> struct net_device *netdev = dev_get_drvdata(dev); >> struct macb *bp = netdev_priv(netdev); >> >> - if (!(device_may_wakeup(&bp->dev->dev))) { >> + if (!(device_may_wakeup(dev))) { >> clk_prepare_enable(bp->pclk); >> clk_prepare_enable(bp->hclk); >> clk_prepare_enable(bp->tx_clk); > -- Nicolas Ferre
Powered by blists - more mailing lists