linux-kernel - Re: [PATCHv2] iommu/arm-smmu: Make remove callback message more informative

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 07 May 2020 16:35:44 +0530
From:   Sai Prakash Ranjan <saiprakash.ranjan@...eaurora.org>
To:     Robin Murphy <robin.murphy@....com>
Cc:     Doug Anderson <dianders@...omium.org>,
        Will Deacon <will@...nel.org>, Joerg Roedel <joro@...tes.org>,
        iommu@...ts.linux-foundation.org,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>
Subject: Re: [PATCHv2] iommu/arm-smmu: Make remove callback message more
 informative

On 2020-05-07 16:03, Robin Murphy wrote:
> On 2020-05-07 11:04 am, Sai Prakash Ranjan wrote:
>> Hi,
>> 
>> On 2020-05-07 05:40, Doug Anderson wrote:
>>> Hi,
>>> 
>>> On Thu, Apr 23, 2020 at 7:35 AM Doug Anderson <dianders@...omium.org> 
>>> wrote:
>>>> 
>>>> Hi,
>>>> 
>>>> On Thu, Apr 23, 2020 at 2:55 AM Sai Prakash Ranjan
>>>> <saiprakash.ranjan@...eaurora.org> wrote:
>>>> >
>>>> > Currently on reboot/shutdown, the following messages are
>>>> > displayed on the console as error messages before the
>>>> > system reboots/shutdown as part of remove callback.
>>>> >
>>>> > On SC7180:
>>>> >
>>>> >   arm-smmu 15000000.iommu: removing device with active domains!
>>>> >   arm-smmu 5040000.iommu: removing device with active domains!
>>>> >
>>>> > Make this error message more informative and less scary.
>>>> >
>>>> > Reported-by: Douglas Anderson <dianders@...omium.org>
>>>> > Suggested-by: Robin Murphy <robin.murphy@....com>
>>>> > Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@...eaurora.org>
>>>> > ---
>>>> >  drivers/iommu/arm-smmu.c | 2 +-
>>>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>>>> 
>>>> Reviewed-by: Douglas Anderson <dianders@...omium.org>
>>> 
>>> Is this patch waiting on anything in particular now?  Do we need
>>> reviews from Robin and/or Will?
>>> 
>> 
>> Waiting for their reviews as they are the maintainers/reviewers :)
> 
> Sorry, this did register at the time, I just felt that it's a bit
> redundant to give a review tag to say "yes, this is exactly what I
> suggested" :)
> 
> That said, I do wish I hadn't forgotten about the dev_notice message
> level, but I think that lies over in the conceptual purity corner
> rather than making any practical difference, so I'm still OK with the
> patch as-is. Will?
> 

I can change to dev_notice if you have strong preference for that.
I chose dev_info since we see the messages on every reboot and that 
makes
it more informational than something to notice everytime.

> 
> p.s. whoever has this entry in their address book for the IOMMU list 
> (Doug?):
> 
> "list@....net:IOMMU DRIVERS <iommu@...ts.linux-foundation.org>, Joerg
> Roedel <joro@...tes.org>," <iommu@...ts.linux-foundation.org>
> 
> it really messes up Thunderbird's ability to generate working headers
> for a reply ;)

Not me ;)

Thanks,
Sai
-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a 
member
of Code Aurora Forum, hosted by The Linux Foundation