lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 7 May 2020 13:13:12 +0200 From: Greg Kroah-Hartman <gregkh@...uxfoundation.org> To: Johan Hovold <johan@...nel.org> Cc: Naresh Kamboju <naresh.kamboju@...aro.org>, linux- stable <stable@...r.kernel.org>, Sasha Levin <sashal@...nel.org>, "David S. Miller" <davem@...emloft.net>, Vince Bridgers <vbridger@...nsource.altera.com>, Florian Fainelli <f.fainelli@...il.com>, Fugang Duan <fugang.duan@....com>, Pantelis Antoniou <pantelis.antoniou@...il.com>, Vitaly Bordug <vbordug@...mvista.com>, Claudiu Manoil <claudiu.manoil@...escale.com>, Li Yang <leoli@...escale.com>, Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>, Felix Fietkau <nbd@...nwrt.org>, John Crispin <blogic@...nwrt.org>, Matthias Brugger <matthias.bgg@...il.com>, Sergei Shtylyov <sergei.shtylyov@...entembedded.com>, Lars Persson <lars.persson@...s.com>, Mugunthan V N <mugunthanvnm@...com>, Grygorii Strashko <grygorii.strashko@...com>, Rob Herring <robh+dt@...nel.org>, Frank Rowand <frowand.list@...il.com>, Andrew Lunn <andrew@...n.ch>, Vivien Didelot <vivien.didelot@...oirfairelinux.com>, Netdev <netdev@...r.kernel.org>, nios2-dev@...ts.rocketboards.org, open list <linux-kernel@...r.kernel.org>, linuxppc-dev@...ts.ozlabs.org, linux-mediatek@...ts.infradead.org, linux-renesas-soc@...r.kernel.org, linux-omap@...r.kernel.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>, lkft-triage@...ts.linaro.org Subject: Re: [PATCH net 11/16] net: ethernet: marvell: mvneta: fix fixed-link phydev leaks On Thu, May 07, 2020 at 08:47:34AM +0200, Greg Kroah-Hartman wrote: > On Thu, May 07, 2020 at 08:44:12AM +0200, Johan Hovold wrote: > > On Thu, May 07, 2020 at 12:27:53AM +0530, Naresh Kamboju wrote: > > > On Tue, 29 Nov 2016 at 00:00, Johan Hovold <johan@...nel.org> wrote: > > > > > > > > Make sure to deregister and free any fixed-link PHY registered using > > > > of_phy_register_fixed_link() on probe errors and on driver unbind. > > > > > > > > Fixes: 83895bedeee6 ("net: mvneta: add support for fixed links") > > > > Signed-off-by: Johan Hovold <johan@...nel.org> > > > > --- > > > > drivers/net/ethernet/marvell/mvneta.c | 5 +++++ > > > > 1 file changed, 5 insertions(+) > > > > > > > > diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c > > > > index 0c0a45af950f..707bc4680b9b 100644 > > > > --- a/drivers/net/ethernet/marvell/mvneta.c > > > > +++ b/drivers/net/ethernet/marvell/mvneta.c > > > > @@ -4191,6 +4191,8 @@ static int mvneta_probe(struct platform_device *pdev) > > > > clk_disable_unprepare(pp->clk); > > > > err_put_phy_node: > > > > of_node_put(phy_node); > > > > + if (of_phy_is_fixed_link(dn)) > > > > + of_phy_deregister_fixed_link(dn); > > > > > > While building kernel Image for arm architecture on stable-rc 4.4 branch > > > the following build error found. > > > > > > drivers/net/ethernet/marvell/mvneta.c:3442:3: error: implicit > > > declaration of function 'of_phy_deregister_fixed_link'; did you mean > > > 'of_phy_register_fixed_link'? [-Werror=implicit-function-declaration] > > > | of_phy_deregister_fixed_link(dn); > > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > | of_phy_register_fixed_link > > > > > > ref: > > > https://gitlab.com/Linaro/lkft/kernel-runs/-/jobs/541374729 > > > > Greg, 3f65047c853a ("of_mdio: add helper to deregister fixed-link > > PHYs") needs to be backported as well for these. > > > > Original series can be found here: > > > > https://lkml.kernel.org/r/1480357509-28074-1-git-send-email-johan@kernel.org > > Ah, thanks for that, I thought I dropped all of the ones that caused > build errors, but missed the above one. I'll go take the whole series > instead. This should now all be fixed up, thanks. greg k-h
Powered by blists - more mailing lists