linux-kernel - Re: [PATCH 4/4] scripts/checkstack.pl: fix arm sp regex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNATkW08MPhiZ4c1ScdZwQ1bu5TnLsj+Tcu1QP7KdmXgNsQ@mail.gmail.com>
Date:   Thu, 7 May 2020 20:58:59 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     Maninder Singh <maninder1.s@...sung.com>
Cc:     "George G. Davis" <george_davis@...tor.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        AMIT SAHRAWAT <a.sahrawat@...sung.com>,
        Vaneet Narang <v.narang@...sung.com>
Subject: Re: [PATCH 4/4] scripts/checkstack.pl: fix arm sp regex

On Thu, May 7, 2020 at 8:43 PM Maninder Singh <maninder1.s@...sung.com> wrote:
>
> Hi Masahiro,
>
> Thanks for review.
> We will integrate your review comements and send v2.
>
> >>
>
> >> so making regex $re for ARM similar to aarch64
> >>
> >> Signed-off-by: Vaneet Narang <v.narang@...sung.com>
> >> Signed-off-by: Maninder Singh <maninder1.s@...sung.com>
> >
> >
> >This looks good to me, and it is a bug fix.
> >
> >Just a question about the SOB.
> >
> >
> >Maninder Singh is the author and also the submitter, right?
> >
> >What does "Signed-off-by: Vaneet Narang <v.narang@...sung.com>" mean?
> >
> >Co-developed-by or something else?
>
> Yes All 4 patches are co-developed by Vaneet and me.
> we were checking stack usage for arm and AARCH64 and found
> some changes in scrips which can help others also.
>

OK. Then,

Co-developed-by: Vaneet Narang <v.narang@...sung.com>

is the correct tag.


Signed-off-by is added when the patch is forwarded by
somebody else. This is not the case.







-- 
Best Regards
Masahiro Yamada