linux-kernel - Re: [PATCH] [net-next, v2] dsa: sja1105: dynamically allocate stats structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200506.174754.1326538013917922662.davem@davemloft.net>
Date:   Wed, 06 May 2020 17:47:54 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     arnd@...db.de
Cc:     olteanv@...il.com, andrew@...n.ch, vivien.didelot@...il.com,
        f.fainelli@...il.com, vladimir.oltean@....com,
        natechancellor@...il.com, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH] [net-next, v2] dsa: sja1105: dynamically allocate
 stats structure

From: Arnd Bergmann <arnd@...db.de>
Date: Tue,  5 May 2020 17:38:19 +0200

> The addition of sja1105_port_status_ether structure into the
> statistics causes the frame size to go over the warning limit:
> 
> drivers/net/dsa/sja1105/sja1105_ethtool.c:421:6: error: stack frame size of 1104 bytes in function 'sja1105_get_ethtool_stats' [-Werror,-Wframe-larger-than=]
> 
> Use dynamic allocation to avoid this.
> 
> Fixes: 336aa67bd027 ("net: dsa: sja1105: show more ethtool statistics counters for P/Q/R/S")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
> v2: remove extra ';'
>     remove bogus include/linux/warnings.h change

Applied, thanks Arnd.