linux-kernel - Re: [PATCH -next] mmc: sdhci-pci-gli: Make sdhci_pci_gli

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFosTSvhKWb51XmNy5R6ynnj2B+k2qrOJGU4Cdkxb7A3-A@mail.gmail.com>
Date:   Thu, 7 May 2020 15:16:04 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Samuel Zou <zou_wei@...wei.com>
Cc:     Adrian Hunter <adrian.hunter@...el.com>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] mmc: sdhci-pci-gli: Make sdhci_pci_gli_resume static

On Thu, 7 May 2020 at 14:14, Samuel Zou <zou_wei@...wei.com> wrote:
>
> Fix the following sparse warning:
>
> drivers/mmc/host/sdhci-pci-gli.c:343:5: warning:
> symbol 'sdhci_pci_gli_resume' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Samuel Zou <zou_wei@...wei.com>

This actually fixes a commit that I on my fixes branch, which is also
targeted for stable.

Therefore, I decided to squash this into the offending commit and
adding your sob tag, with a note about what you fixed.

Kind regards
Uffe

> ---
>  drivers/mmc/host/sdhci-pci-gli.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-pci-gli.c b/drivers/mmc/host/sdhci-pci-gli.c
> index bdb6336..fd76aa6 100644
> --- a/drivers/mmc/host/sdhci-pci-gli.c
> +++ b/drivers/mmc/host/sdhci-pci-gli.c
> @@ -340,7 +340,7 @@ static u32 sdhci_gl9750_readl(struct sdhci_host *host, int reg)
>  }
>
>  #ifdef CONFIG_PM_SLEEP
> -int sdhci_pci_gli_resume(struct sdhci_pci_chip *chip)
> +static int sdhci_pci_gli_resume(struct sdhci_pci_chip *chip)
>  {
>         struct sdhci_pci_slot *slot = chip->slots[0];
>
> --
> 2.6.2
>