lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 6 May 2020 18:11:17 -0700 From: Brian Geffon <bgeffon@...gle.com> To: Joel Fernandes <joel@...lfernandes.org> Cc: Andrew Morton <akpm@...ux-foundation.org>, "Michael S . Tsirkin" <mst@...hat.com>, LKML <linux-kernel@...r.kernel.org>, linux-mm <linux-mm@...ck.org>, Andrea Arcangeli <aarcange@...hat.com>, Sonny Rao <sonnyrao@...gle.com>, Minchan Kim <minchan@...nel.org>, "Kirill A . Shutemov" <kirill@...temov.name> Subject: Re: [PATCH] userfaultfd: fix remap event with MREMAP_DONTUNMAP. > > - mremap_userfaultfd_complete(&uf, addr, new_addr, old_len); > > + mremap_userfaultfd_complete(&uf, addr, ret, old_len); > > Not super familiar with this code, but thought I'd ask, does ret > to be checked for -ENOMEM before calling mremap_userfaultfd_complete? > Sorry if I missed something. No, mremap_userfaultfd_complete will do a check similar to offset_in_page() by checking the page mask. It does (to & ~PAGE_MASK) to check for a non-aligned "to" value, so we're good. Additionally, earlier in the process then ctx will be null because we will have never called mremap_userfaultfd_prep, and mremap_userfaultfd_complete will check if there is a context before proceeding. Brian
Powered by blists - more mailing lists