linux-kernel - Re: [PATCH v4] tools/bootconfig: fix resource leak in apply

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <757dc0e5-3ab7-b00b-11dc-e94a903e3901@web.de>
Date:   Fri, 8 May 2020 15:42:40 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Yunfeng Ye <yeyunfeng@...wei.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Masami Hiramatsu <mhiramat@...nel.org>
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Shiyuan Hu <hushiyuan@...wei.com>,
        Hewenliang <hewenliang4@...wei.com>,
        Dan Carpenter <dan.carpenter@...cle.com>
Subject: Re: [PATCH v4] tools/bootconfig: fix resource leak in apply_xbc()

> An error is found by a internel analysis tool:
>   "Memory leak: data" and "Resource leak: fd" in tools/bootconfig/main.c

If such an information will ever be integrated into a final commit message,
I would prefer a wording variant like the following.

   Two issues were pointed out by an internal source code analysis tool:
   * Line …:
     Memory leak: data

   * Line …:
     Resource leak: fd


Each of these issues has got a different importance for this function implementation.


> Fix the @data and @fd allocations that are leaked in the error path of
> apply_xbc().

How do you think about to replace the @ characters by other delimiters
for the relevant identifiers?

Regards,
Markus