linux-kernel - Re: [PATCH v2 0/2] Add TI tps6598x DT binding and probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200508140132.GA1264047@kuha.fi.intel.com>
Date:   Fri, 8 May 2020 17:01:32 +0300
From:   Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:     Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
        Angus Ainslie <angus@...ea.ca>
Cc:     robh+dt@...nel.org, linux-usb@...r.kernel.org,
        devicetree@...r.kernel.org, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org, nikolaus.voss@...wensteinmedical.de,
        andriy.shevchenko@...ux.intel.com, garsilva@...eddedor.com,
        keescook@...omium.org
Subject: Re: [PATCH v2 0/2] Add TI tps6598x DT binding and probe

Hi,

On Thu, May 07, 2020 at 10:47:31PM +0100, Bryan O'Donoghue wrote:
> V2:
> - Put myself down as sole schema maintainer as suggested - Andy
> - Fixed whitespace typo - Andy
> - Removed ifdef and of_match_ptr() - Andy
> 
> V1:
> This simple series adds DT binding yaml and a DT lookup table for the
> tps6598x.
> 
> Its possible to use i2c id_table to match the 'compatible = "ti,tps6598x"
> and probe that way, however I think it is worthwhile adding a specific OF
> way of doing it and having an accompanying yaml as an example.
> 
> Bryan O'Donoghue (2):
>   dt-bindings: usb: Add TI tps6598x device tree binding documentation
>   usb: typec: tps6598x: Add OF probe binding
> 
>  .../devicetree/bindings/usb/ti,tps6598x.yaml  | 64 +++++++++++++++++++
>  drivers/usb/typec/tps6598x.c                  |  7 ++
>  2 files changed, 71 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/usb/ti,tps6598x.yaml

There was already a series from Angus [1] for this. The bindings
looked a bit different, but I think we should use these, because in
the DT bindings from Angus there appeared to be definitions for OF
graph that was not used. Or maybe I got it wrong?

Angus, is it OK if we use these patches instead the ones from you?

[1] https://lore.kernel.org/linux-usb/20200506191718.2144752-1-angus@akkea.ca/

thanks,

-- 
heikki