linux-kernel - Re: [PATCH v2] KVM: SVM: Disable AVIC before setting V

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 8 May 2020 23:32:34 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Suravee Suthikulpanit <suravee.suthikulpanit@....com>,
        linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
        pbonzini@...hat.com, joro@...tes.org, jon.grimm@....com,
        mlevitsk@...hat.com
Cc:     kbuild-all@...ts.01.org, pbonzini@...hat.com, joro@...tes.org,
        jon.grimm@....com, mlevitsk@...hat.com
Subject: Re: [PATCH v2] KVM: SVM: Disable AVIC before setting V_IRQ

Hi Suravee,

I love your patch! Yet something to improve:

[auto build test ERROR on kvm/linux-next]
[also build test ERROR on vhost/linux-next linus/master v5.7-rc4 next-20200507]
[cannot apply to linux/master]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Suravee-Suthikulpanit/KVM-SVM-Disable-AVIC-before-setting-V_IRQ/20200507-111704
base:   https://git.kernel.org/pub/scm/virt/kvm/kvm.git linux-next
config: x86_64-rhel (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   arch/x86/kvm/x86.c: In function 'kvm_request_apicv_update':
>> arch/x86/kvm/x86.c:8107:2: error: implicit declaration of function 'kvm_make_all_cpus_request_except'; did you mean 'kvm_make_all_cpus_request'? [-Werror=implicit-function-declaration]
     kvm_make_all_cpus_request_except(kvm, KVM_REQ_APICV_UPDATE,
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     kvm_make_all_cpus_request
   cc1: all warnings being treated as errors

vim +8107 arch/x86/kvm/x86.c

  8065	
  8066	/*
  8067	 * NOTE: Do not hold any lock prior to calling this.
  8068	 *
  8069	 * In particular, kvm_request_apicv_update() expects kvm->srcu not to be
  8070	 * locked, because it calls __x86_set_memory_region() which does
  8071	 * synchronize_srcu(&kvm->srcu).
  8072	 */
  8073	void kvm_request_apicv_update(struct kvm *kvm, bool activate, ulong bit)
  8074	{
  8075		struct kvm_vcpu *except;
  8076		unsigned long old, new, expected;
  8077	
  8078		if (!kvm_x86_ops.check_apicv_inhibit_reasons ||
  8079		    !kvm_x86_ops.check_apicv_inhibit_reasons(bit))
  8080			return;
  8081	
  8082		old = READ_ONCE(kvm->arch.apicv_inhibit_reasons);
  8083		do {
  8084			expected = new = old;
  8085			if (activate)
  8086				__clear_bit(bit, &new);
  8087			else
  8088				__set_bit(bit, &new);
  8089			if (new == old)
  8090				break;
  8091			old = cmpxchg(&kvm->arch.apicv_inhibit_reasons, expected, new);
  8092		} while (old != expected);
  8093	
  8094		if (!!old == !!new)
  8095			return;
  8096	
  8097		trace_kvm_apicv_update_request(activate, bit);
  8098		if (kvm_x86_ops.pre_update_apicv_exec_ctrl)
  8099			kvm_x86_ops.pre_update_apicv_exec_ctrl(kvm, activate);
  8100	
  8101		/*
  8102		 * Sending request to update APICV for all other vcpus,
  8103		 * while update the calling vcpu immediately instead of
  8104		 * waiting for another #VMEXIT to handle the request.
  8105		 */
  8106		except = kvm_get_running_vcpu();
> 8107		kvm_make_all_cpus_request_except(kvm, KVM_REQ_APICV_UPDATE,
  8108						 except);
  8109		if (except)
  8110			kvm_vcpu_update_apicv(except);
  8111	}
  8112	EXPORT_SYMBOL_GPL(kvm_request_apicv_update);
  8113	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (44840 bytes)