linux-kernel - Re: [PATCH] ASoC: cros_ec_codec: allocate shash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <158896033901.2700.3513138380933416589.b4-ty@kernel.org>
Date:   Fri, 08 May 2020 18:52:19 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Arnd Bergmann <arnd@...db.de>,
        Cheng-Yi Chiang <cychiang@...omium.org>
Cc:     Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Guenter Roeck <groeck@...omium.org>,
        linux-kernel@...r.kernel.org, Liam Girdwood <lgirdwood@...il.com>,
        Benson Leung <bleung@...omium.org>,
        alsa-devel@...a-project.org, Takashi Iwai <tiwai@...e.com>,
        Yu-Hsuan Hsu <yuhsuan@...omium.org>,
        Tzung-Bi Shih <tzungbi@...gle.com>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
Subject: Re: [PATCH] ASoC: cros_ec_codec: allocate shash_desc dynamically

On Thu, 7 May 2020 23:33:51 +0200, Arnd Bergmann wrote:
> The wov_hotword_model_put() function has multiple large variables on
> its stack, the largest of which is the result of SHASH_DESC_ON_STACK().
> In total, this exceeds the warning limit for 32-bit architectures:
> 
> sound/soc/codecs/cros_ec_codec.c:776:12: error: stack frame size of 1152 bytes in function 'wov_hotword_model_put' [-Werror,-Wframe-larger-than=]
> 
> The function already has a dynamic crypto_alloc_shash() allocation, so
> using kmalloc() for the descriptor is correct as well and does not
> introduce any additional failure scenarios. With this, the stack usage
> of wov_hotword_model_put() gets reduced to 480 bytes in my test
> configuration.

Applied to

   local tree asoc/for-5.7

Thanks!

[1/1] ASoC: cros_ec_codec: allocate shash_desc dynamically
      (no commit info)

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark