linux-kernel - Re: [PATCH net-next v1] hinic: add three net_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200508143825.2938a6e0@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 8 May 2020 14:38:25 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Luo bin <luobin9@...wei.com>
Cc:     <davem@...emloft.net>, <linux-kernel@...r.kernel.org>,
        <netdev@...r.kernel.org>, <luoxianjun@...wei.com>,
        <yin.yinshi@...wei.com>, <cloud.wangxiaoyun@...wei.com>
Subject: Re: [PATCH net-next v1] hinic: add three net_device_ops of vf

On Thu, 7 May 2020 18:21:19 +0000 Luo bin wrote:
> @@ -899,8 +920,18 @@ int hinic_init_cmdqs(struct hinic_cmdqs *cmdqs, struct hinic_hwif *hwif,
>  
>  	hinic_ceq_register_cb(&func_to_io->ceqs, HINIC_CEQ_CMDQ, cmdqs,
>  			      cmdq_ceq_handler);
> +
> +	err = hinic_set_cmdq_depth(hwdev, CMDQ_DEPTH);
> +	if (err) {
> +		dev_err(&hwif->pdev->dev, "Failed to set cmdq depth\n");
> +		goto err_set_cmdq_depth;
> +	}
> +
>  	return 0;
>  
> +err_set_cmdq_depth:
> +	hinic_ceq_unregister_cb(&func_to_io->ceqs, HINIC_CEQ_CMDQ);

Looking at code in hinic_free_cmdqs(), isn't this also missing:

	cmdq_type = HINIC_CMDQ_SYNC;
	for (; cmdq_type < HINIC_MAX_CMDQ_TYPES; cmdq_type++)
		free_cmdq(&cmdqs->cmdq[cmdq_type]);
?

>  err_cmdq_ctxt:
>  	hinic_wqs_cmdq_free(&cmdqs->cmdq_pages, cmdqs->saved_wqs,
>  			    HINIC_MAX_CMDQ_TYPES);