linux-kernel - Re: [PATCH] parisc: use -fno-strict-aliasing for decompressor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a16Qb2-H5UGMftonvEAuJ2LrKMO4nVudg+JD6HtuYR==Q@mail.gmail.com>
Date:   Fri, 8 May 2020 23:43:16 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Helge Deller <deller@....de>
Cc:     "James E.J. Bottomley" <James.Bottomley@...senpartnership.com>,
        kbuild test robot <lkp@...el.com>,
        Parisc List <linux-parisc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] parisc: use -fno-strict-aliasing for decompressor

On Fri, May 8, 2020 at 11:40 PM Helge Deller <deller@....de> wrote:
> On 08.05.20 11:35, Arnd Bergmann wrote:
> > An experimental patch series of mine reworks how warnings are processed
> > in Kbuild. A side effect is a new warning about a harmless aliasing
> > rule violation in an inline function:
> >
> > In file included from
> > include/linux/rhashtable-types.h:15:0,
> >                  from include/linux/ipc.h:7,
> >                  from include/uapi/linux/sem.h:5,
> >                  from include/linux/sem.h:5,
> >                  from include/linux/sched.h:15,
> >                  from include/linux/uaccess.h:6,
> >                  from arch/parisc/boot/compressed/misc.c:7:
> > include/linux/workqueue.h: In function 'work_static':
> > include/linux/workqueue.h:212:2: warning: dereferencing
> > type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
> >   return *work_data_bits(work) & WORK_STRUCT_STATIC;
> >
> > Make the decompressor use -fno-strict-aliasing like the rest of
> > the kernel for consistency, and to ensure this warning never makes
> > it into a release.
> >
> > Reported-by: kbuild test robot <lkp@...el.com>
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
>
> Acked-by: Helge Deller <deller@....de>
>
> Arnd, will you take it through your trees when you push your experimental
> patches, or do you want me to take it through the parisc tree?

Please take it through your tree. It will take me a while to finish my
series, and having one less change will make it easier to review.

       Arnd