linux-kernel - Re: [PATCH 2/2] PCI: Prevent Pericom USB controller OHCI/EHCI PME# defect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200508215514.GA93513@bjorn-Precision-5520>
Date:   Fri, 8 May 2020 16:55:14 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Kai-Heng Feng <kai.heng.feng@...onical.com>
Cc:     bhelgaas@...gle.com,
        "open list:PCI SUBSYSTEM" <linux-pci@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] PCI: Prevent Pericom USB controller OHCI/EHCI PME#
 defect

On Fri, May 08, 2020 at 02:53:41PM +0800, Kai-Heng Feng wrote:
> Both Pericom OHCI and EHCI devices support PME# from all power states:
> 06:00.0 USB controller [0c03]: Pericom Semiconductor PI7C9X442SL USB OHCI Controller [12d8:400e] (rev 01) (prog-if 10 [OHCI])
> 	Subsystem: Pericom Semiconductor PI7C9X442SL USB OHCI Controller [12d8:400e]
> 	Control: I/O+ Mem+ BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR+ FastB2B- DisINTx-
> 	Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
> 	Interrupt: pin A routed to IRQ 17
> 	Region 0: Memory at a5502000 (32-bit, non-prefetchable) [size=4K]
> 	Capabilities: [80] Power Management version 3
> 		Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=375mA PME(D0+,D1+,D2+,D3hot+,D3cold+)
> 		Status: D3 NoSoftRst+ PME-Enable+ DSel=0 DScale=0 PME-
> 
> 06:00.2 USB controller [0c03]: Pericom Semiconductor PI7C9X442SL USB EHCI Controller [12d8:400f] (rev 01) (prog-if 20 [EHCI])
> 	Subsystem: Pericom Semiconductor PI7C9X442SL USB EHCI Controller [12d8:400f]
> 	Control: I/O+ Mem+ BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR+ FastB2B- DisINTx-
> 	Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
> 	Interrupt: pin C routed to IRQ 19
> 	Region 0: Memory at a5500000 (32-bit, non-prefetchable) [size=256]
> 	Capabilities: [80] Power Management version 3
> 		Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=375mA PME(D0+,D1+,D2+,D3hot+,D3cold+)
> 		Status: D3 NoSoftRst+ PME-Enable+ DSel=0 DScale=0 PME-
> 
> Though my original approach [1] appears to work, further testing shows
> that there is a 20% chance PME# won't be asserted when USB device is
> plugged.
> 
> So remove the PME support for both devices to make USB plugging works.
> 
> [1] https://lore.kernel.org/lkml/20191227092405.29588-1-kai.heng.feng@canonical.com/
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=205981
> 
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@...onical.com>

Applied both with Greg's ack to pci/pm for v5.8, thanks!

I added stable tags to both; let me know if you don't want that.

> ---
>  drivers/pci/quirks.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index ca9ed5774eb1..db2590243f0d 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -5568,6 +5568,18 @@ static void pci_fixup_no_d0_pme(struct pci_dev *dev)
>  }
>  DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ASMEDIA, 0x2142, pci_fixup_no_d0_pme);
>  
> +/*
> + * Device [12d8:0x400e] and [12d8:0x400f]
> + * PME# doesn't always get asserted on all power states claim to support PME#
> + */
> +static void pci_fixup_no_pme(struct pci_dev *dev)
> +{
> +	pci_info(dev, "PME# isn't reliable, disabling it\n");
> +	dev->pme_support = 0;
> +}
> +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_PERICOM, 0x400e, pci_fixup_no_pme);
> +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_PERICOM, 0x400f, pci_fixup_no_pme);
> +
>  static void apex_pci_fixup_class(struct pci_dev *pdev)
>  {
>  	pdev->class = (PCI_CLASS_SYSTEM_OTHER << 8) | pdev->class;
> -- 
> 2.17.1
>