lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 7 May 2020 17:04:48 -0700 From: Andrew Morton <akpm@...ux-foundation.org> To: Walter Wu <walter-zh.wu@...iatek.com> Cc: Bart Van Assche <bvanassche@....org>, Matthias Brugger <matthias.bgg@...il.com>, Thomas Gleixner <tglx@...utronix.de>, Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...nel.org>, Josh Poimboeuf <jpoimboe@...hat.com>, <linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>, <linux-mediatek@...ts.infradead.org>, wsd_upstream <wsd_upstream@...iatek.com> Subject: Re: [PATCH v2] stacktrace: cleanup inconsistent variable type On Wed, 6 May 2020 10:18:24 +0800 Walter Wu <walter-zh.wu@...iatek.com> wrote: > On Wed, 2020-04-22 at 18:21 -0700, Bart Van Assche wrote: > > On 4/20/20 6:35 PM, Walter Wu wrote: > > > Modify the variable type of 'skip' member of struct stack_trace. > > > In theory, the 'skip' variable type should be unsigned int. > > > There are two reasons: > > > - The 'skip' only has two situation, 1)Positive value, 2)Zero > > > - The 'skip' of struct stack_trace has inconsistent type with struct > > > stack_trace_data, it makes a bit confusion in the relationship between > > > struct stack_trace and stack_trace_data. > > > > Reviewed-by: Bart Van Assche <bvanassche@....org> > > Hi Andrew, > > Would you know why not to be picked up this patch yet? > Do I miss somethings? I'd decided to pass on this because it's so minor. We inappropriately use signed types in soooo many places :(
Powered by blists - more mailing lists