linux-kernel - Re: [PATCH -next] drm/ast: Make ast_primary_plane_helper_atomic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6fab133b-9f94-fff5-8c87-1d7c6d3e9043@suse.de>
Date:   Fri, 8 May 2020 08:44:25 +0200
From:   Thomas Zimmermann <tzimmermann@...e.de>
To:     Samuel Zou <zou_wei@...wei.com>, airlied@...hat.com,
        airlied@...ux.ie, daniel@...ll.ch
Cc:     linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH -next] drm/ast: Make
 ast_primary_plane_helper_atomic_update static


I'll add your patch to drm-misc-next. Thanks!

Am 07.05.20 um 04:40 schrieb Samuel Zou:
> Fix the following sparse warning:
> 
> drivers/gpu/drm/ast/ast_mode.c:564:6: warning:
> symbol 'ast_primary_plane_helper_atomic_update'
> was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Samuel Zou <zou_wei@...wei.com>

Reviewed-by: Thomas Zimmermann <tzimmermann@...e.de>

> ---
>  drivers/gpu/drm/ast/ast_mode.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c
> index 7062bcd..4ddf770 100644
> --- a/drivers/gpu/drm/ast/ast_mode.c
> +++ b/drivers/gpu/drm/ast/ast_mode.c
> @@ -561,8 +561,9 @@ static int ast_primary_plane_helper_atomic_check(struct drm_plane *plane,
>  	return 0;
>  }
>  
> -void ast_primary_plane_helper_atomic_update(struct drm_plane *plane,
> -					    struct drm_plane_state *old_state)
> +static void
> +ast_primary_plane_helper_atomic_update(struct drm_plane *plane,
> +				       struct drm_plane_state *old_state)
>  {
>  	struct ast_private *ast = plane->dev->dev_private;
>  	struct drm_plane_state *state = plane->state;
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer



Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)