linux-kernel - Re: [PATCH 1/1] mm: remove an unnecessary goto jump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6d06207c-5b1c-d526-ef01-e437c7696dd3@redhat.com>
Date:   Fri, 8 May 2020 10:06:27 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Zhen Lei <thunder.leizhen@...wei.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-mm <linux-mm@...ck.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] mm: remove an unnecessary goto jump

On 05.05.20 13:58, Zhen Lei wrote:
> This "goto" doesn't reduce any code, but bother the readers.

"mm/page_io.c: mm: remove an unnecessary goto in generic_swapfile_activate"

> 
> Signed-off-by: Zhen Lei <thunder.leizhen@...wei.com>
> ---
>  mm/page_io.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/page_io.c b/mm/page_io.c
> index 76965be1d40e..b1d4f4558e6b 100644
> --- a/mm/page_io.c
> +++ b/mm/page_io.c
> @@ -235,10 +235,10 @@ int generic_swapfile_activate(struct swap_info_struct *sis,
>  	sis->highest_bit = page_no - 1;
>  out:
>  	return ret;
> +

nit: I'd just not mess with newlines here.

>  bad_bmap:
>  	pr_err("swapon: swapfile has holes\n");
> -	ret = -EINVAL;
> -	goto out;
> +	return -EINVAL;
>  }
>  
>  /*
> 

apart from that

Reviewed-by: David Hildenbrand <david@...hat.com>


-- 
Thanks,

David / dhildenb